Skip to content

Conversation

@saturley-hall
Copy link
Member

@saturley-hall saturley-hall commented Jan 27, 2026

Overview:

Update CI to check for all the banned dependencies in deny.toml

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Chores
    • Enhanced dependency validation workflow to enable comprehensive feature testing during security and licensing checks, improving the quality assurance process.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
@saturley-hall saturley-hall requested a review from a team as a code owner January 27, 2026 22:22
@github-actions github-actions bot added the ci Issues/PRs that reference CI build/test label Jan 27, 2026
Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

Walkthrough

The GitHub Actions workflow for pre-merge Rust checks was updated to invoke cargo-deny with --all-features instead of --no-default-features, changing the feature scope evaluated during the denial checks while maintaining other command flags.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/pre-merge-rust.yml
Modified cargo-deny invocation to check all features (--all-features) instead of checking with no default features (--no-default-features)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A single flag swap, so clean and bright,
From no-defaults to all-features in sight,
The workflow now checks with broader scope,
Cargo-deny hops with renewed hope! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating CI configuration to check the ban list via cargo-deny with all features enabled.
Description check ✅ Passed The description follows the template structure with Overview and Details sections, but the Details section is empty and the Related Issues section contains only a placeholder without a concrete issue number.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Issues/PRs that reference CI build/test size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants