Skip to content

fix: correct SGLang metrics prefix from sglang_ to sglang: #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keivenchang merged 1 commit into from
Jan 28, 2026
+2 −3
Merged

fix: correct SGLang metrics prefix from sglang_ to sglang: #5701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion components/src/dynamo/sglang/publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ def setup_prometheus_registry(
endpoint=generate_endpoint,
registry=registry,
metric_prefix_filters=["sglang:"],
add_prefix="sglang_",
)
return registry

Expand Down
4 changes: 2 additions & 2 deletions tests/utils/payloads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,8 +634,8 @@ def metric_pattern(name):
metrics_to_check.append(
MetricCheck(
# Check: Minimum count of unique sglang:* metrics
name="sglang_*",
pattern=lambda name: r"^sglang_\w+",
name="sglang:*",
pattern=lambda name: r"^sglang:\w+",
validator=lambda value: len(set(value))
>= 20, # 80% of typical ~25 sglang metrics (excluding _bucket) as of 2025-10-22 (but will grow)
error_msg=lambda name, value: f"Expected at least 20 unique sglang:* metrics, but found only {len(set(value))}",
Expand Down
Loading