Skip to content

Conversation

@grahamking
Copy link
Contributor

@grahamking grahamking commented Jan 27, 2026

deny.toml was meant to check this, but our cargo deny incantation wasn't quite right.

Crate async-openai now uses the workspace version of crates.

Summary by CodeRabbit

  • Chores
    • Updated dependency configurations to optimize package management and version resolution.
    • Consolidated dependency specifications across project modules for consistency.
    • Enhanced dependency feature flags for improved build compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

`deny.toml` was meant to check this, but our `cargo deny` incantation
wasn't quite right.

Crate async-openai now uses the workspace version of crates.

Signed-off-by: Graham King <grahamk@nvidia.com>
@grahamking grahamking requested a review from a team as a code owner January 27, 2026 23:00
@github-actions github-actions bot added the chore label Jan 27, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

Walkthrough

Two Cargo.toml files updated: root file adjusts dependency features for dynamo-async-openai, serde, and tokio-util; library file consolidates dependencies to use workspace-wide versions instead of individual specifications.

Changes

Cohort / File(s) Summary
Dependency Feature Adjustments
Cargo.toml
Removed rustls feature from dynamo-async-openai, added "rc" to serde features, and extended tokio-util features with "io-util".
Workspace Dependency Consolidation
lib/async-openai/Cargo.toml
Converted 12+ dependencies (futures, rand, reqwest, serde, serde_json, thiserror, tokio, tokio-stream, tokio-util, tracing, url, uuid, derive_builder, bytes) to use workspace-wide version resolution; adjusted optional dependencies and dev-dependencies accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Workspace branches spread so wide,
Dependencies unified with pride,
Features tweaked and versions aligned,
Cargo knows what's left behind,
A cleaner manifest we find! 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete. It lacks most required template sections including Overview, detailed Changes, reviewer starting points, and Related Issues. Provide a complete description following the template: add Overview section describing the motivation, expand Details section explaining all changes made, specify files for reviewer focus, and reference any related GitHub issues.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: Remove native-tls / openssl dependency' is partially related to the changeset; it addresses removing a dependency, but the actual changes focus on consolidating dependencies via workspace configuration rather than removing native-tls/openssl entirely.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@lib/async-openai/Cargo.toml`:
- Around line 43-50: The tokio-tungstenite dependency currently disables TLS by
setting default-features = false, breaking realtime wss:// connections; update
the tokio-tungstenite entry to enable a rustls-based TLS feature (e.g., set
features = ["rustls-tls"] or features = ["rustls-tls-webpki-roots"] if you want
bundled roots) while keeping optional = true and default-features = false so TLS
is available when the realtime feature is enabled; edit the tokio-tungstenite
line in Cargo.toml to include the chosen rustls feature.

@grahamking grahamking enabled auto-merge (squash) January 27, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants