-
Notifications
You must be signed in to change notification settings - Fork 822
chore: Remove native-tls / openssl dependency #5703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
`deny.toml` was meant to check this, but our `cargo deny` incantation wasn't quite right. Crate async-openai now uses the workspace version of crates. Signed-off-by: Graham King <grahamk@nvidia.com>
WalkthroughTwo Cargo.toml files updated: root file adjusts dependency features for dynamo-async-openai, serde, and tokio-util; library file consolidates dependencies to use workspace-wide versions instead of individual specifications. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@lib/async-openai/Cargo.toml`:
- Around line 43-50: The tokio-tungstenite dependency currently disables TLS by
setting default-features = false, breaking realtime wss:// connections; update
the tokio-tungstenite entry to enable a rustls-based TLS feature (e.g., set
features = ["rustls-tls"] or features = ["rustls-tls-webpki-roots"] if you want
bundled roots) while keeping optional = true and default-features = false so TLS
is available when the realtime feature is enabled; edit the tokio-tungstenite
line in Cargo.toml to include the chosen rustls feature.
deny.tomlwas meant to check this, but ourcargo denyincantation wasn't quite right.Crate async-openai now uses the workspace version of crates.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.