-
Notifications
You must be signed in to change notification settings - Fork 822
docs: DYN-1967 update metrics docs after kvstats removal #5704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: DYN-1967 update metrics docs after kvstats removal #5704
Conversation
Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
WalkthroughThe pull request updates KV cache and router metrics throughout documentation and code examples. The changes replace Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@fern/pages/observability/metrics.md`:
- Around line 125-131: The metric name documented as
`dynamo_component_kv_cache_events_applied` is missing the required `_total`
Prometheus suffix; update the documentation to
`dynamo_component_kv_cache_events_applied_total` wherever it appears
(referencing the KV Router metric entry and the `kv_cache_events_applied` metric
mention) to match team conventions (see `prometheus_names.rs` and PR 3035) while
leaving the existing label set (`event_type`, `status`) unchanged.
Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
28a4b85 to
d924fae
Compare
biswapanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from k8s perspective
jh-nv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Overview:
Update Dynamo docs after the
kvstatsPrometheus names removal (DYN-1967).Details:
Where should the reviewer start?
docs/observability/metrics.md
docs/kubernetes/autoscaling.md
Related Issues: (use Closes / Fixes / Resolves / Relates to)
Relates to DYN-1967
/coderabbit profile chill
Summary by CodeRabbit
Documentation
kv_cache_events_appliedcounter metric with event tracking labels.Chores
✏️ Tip: You can customize this high-level summary in your review settings.