test: add TAS advanced scenarios and edge case tests #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 4-level topology hierarchy setup (zone/block/rack/host) - Add KAI Topology verification utilities - Add topology constraint verification helpers - Include 2 foundational tests: * TI1: Topology infrastructure verification * BP1: Multiple cliques with different constraints - Update dependencies to KAI Scheduler v0.13.0-rc1 - Add Makefile target for selective test execution - Add topology-test skaffold profile Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Add 5 tests for simple topology constraint scenarios: - SL1: PCS-only constraint (inherited by children) - SL2: PCSG-only constraint - SL3: No topology constraints (baseline) - PC1: Host-level constraint (strictest packing) - ZL1: Zone-level constraint These tests verify constraint behavior at different resource levels (PCS, PCSG, PCLQ) and topology domains (zone, rack, host, none). Builds on PR ai-dynamo#348 (infrastructure). Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Add 5 tests for scaling and hierarchical topology patterns: - SP1: Full hierarchy with cascading constraints (PCS→PCSG→PCLQ) - SP2: PCS + PCLQ constraint combination - SP3: PCSG scaling with topology constraints - SP5: PCSG + PCLQ without parent PCS constraint - SP8: Large scaling ratio (6+ replicas) These tests verify: - Hierarchical constraint inheritance and overrides - PCSG-level topology constraint propagation - Large-scale PCSG replica handling - KAI PodGroup SubGroup structure with constraints Builds on PR ai-dynamo#349 (simple level tests). Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Add 4 tests for advanced scenarios and edge cases: - EC1: Insufficient nodes for constraint (error handling) - MR1: Multi-replica PCS with rack constraint - SP4: Disaggregated inference with multiple PCSGs - SP9: Multi-replica PCS with 3-level hierarchy (most complex) These tests verify: - Error cases with insufficient topology domains - Multi-replica PCS scaling behavior - Disaggregated inference patterns (prefill/decode/router) - Complex 3-level hierarchies across multiple PCS replicas - KAI PodGroup verification for scaled PodGangs Completes TAS e2e test suite (part 4 of 4). Signed-off-by: Ron Kahn <rkahn@nvidia.com>
Ronkahn21
requested review from
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
This was referenced Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the final 4 test scenarios for advanced patterns and edge cases in Topology Aware Scheduling (TAS), completing the e2e test suite.
Tests Added:
Test Coverage:
This PR completes the TAS e2e test suite (part 4 of 4).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Dependencies:
Test Verification:
-tags e2eComplete Test Suite Summary:
Total: 16 tests covering infrastructure, simple patterns, scaling, hierarchies, and edge cases
File Summary:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: