add tests for updateObservedGeneration functions #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gflarity
requested review from
Ronkahn21,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
gflarity
added
the
kind/cleanup
Ronkahn21
approved these changes
Jan 22, 2026
gflarity
force-pushed
the
update_observed_generation_unit_tests
branch
from
68fcd65 to
9c95d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds unit tests for the
updateObservedGenerationfunctions in the PodClique, PodCliqueSet, and PodCliqueScalingGroup controllers.When reviewing PR #337 (commit 24ae6c1) after merge, I noticed the
updateObservedGenerationfunctions lacked test coverage. This PR adds comprehensive unit tests covering three scenarios:Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
I noticed there weren't any tests on the
updateObservedGenerationfunctions when reviewing 24ae6c1 after merge, so I created some.Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: