Skip to content

Conversation

@danbar2
Copy link
Contributor

@danbar2 danbar2 commented Jan 20, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a API change?


Additional documentation e.g., enhancement proposals, usage docs, etc.:


shayasoolin
shayasoolin previously approved these changes Jan 20, 2026
@Ronkahn21 Ronkahn21 requested a review from Copilot January 20, 2026 13:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the rolling update functionality and fixes test infrastructure for e2e tests. The main focus is on fixing Test_RU10 to properly verify delete-first rolling update behavior when resources are insufficient, and improving Docker image handling in the test setup.

Changes:

  • Fixed logic in mutateUpdatedReplica to correctly track updated replicas when a rolling update completes
  • Updated Test_RU10 to verify delete-first strategy behavior with cordoned nodes
  • Refactored Docker image pulling logic to avoid duplication and add authentication support

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
operator/internal/controller/podclique/reconcilestatus.go Added handling for the window between rolling update completion and hash update
operator/e2e/tests/rolling_updates_test.go Uncommented and fixed Test_RU9 and Test_RU10, updated timeouts and verification logic
operator/e2e/setup/shared_cluster.go Added Docker authentication support and extracted common image pull logic
operator/e2e/setup/k8s_clusters.go Refactored to use common image pull helper function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Ronkahn21
Ronkahn21 previously approved these changes Jan 20, 2026
Copy link
Contributor

@gflarity gflarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments around the utils, but looks like this also addresses
#315. Nice!

@gflarity gflarity self-requested a review January 21, 2026 19:34
Copy link
Contributor

@gflarity gflarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, one question and one comment.

@danbar2 danbar2 force-pushed the danbar/e2e-rolling-update-10 branch from 53c1b55 to f44d01a Compare January 22, 2026 06:41
@danbar2 danbar2 requested a review from gflarity January 22, 2026 06:43
@danbar2 danbar2 force-pushed the danbar/e2e-rolling-update-10 branch from f44d01a to ad88be8 Compare January 22, 2026 13:19
@sanjaychatterjee
Copy link
Collaborator

@unmarshall please review this fix for rolling updates

@danbar2 danbar2 force-pushed the danbar/e2e-rolling-update-10 branch from ad88be8 to 5d0c9d6 Compare January 25, 2026 08:13
@danbar2 danbar2 merged commit 428ba0d into ai-dynamo:main Jan 26, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants