Skip to content

Conversation

@gflarity
Copy link
Contributor

@gflarity gflarity commented Jan 20, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR changes the e2e test diagnostic utility to gather all operator logs after a test failure, instead of just the last 2000 lines. This ensures complete diagnostic information is available when debugging test failures, rather than potentially missing earlier relevant logs that occurred before the failure.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Small change to operator/e2e/tests/debug_utils.go:

  • Removed the operatorLogLines constant (previously set to 2000)
  • Removed the TailLines option from the pod log request, which causes it to fetch all logs

Does this PR introduce a API change?

NONE

Additional documentation e.g., enhancement proposals, usage docs, etc.:

NONE

@gflarity gflarity force-pushed the diag_gather_all_operator_logs branch from c6e040c to 238bc2d Compare January 21, 2026 14:55
@gflarity gflarity added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed run-e2e labels Jan 21, 2026
@gflarity gflarity marked this pull request as ready for review January 21, 2026 15:03
@gflarity gflarity changed the title temporarily run only RU19 to trigger race condition and debug Gather all operator logs on e2e test failure Jan 21, 2026
danbar2
danbar2 previously approved these changes Jan 22, 2026
shayasoolin
shayasoolin previously approved these changes Jan 22, 2026
Copy link

@shayasoolin shayasoolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be safer to keep the tail, just have it much longer, say 32K lines.

Copy link
Contributor

@Ronkahn21 Ronkahn21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we implement a line-limit control for logs? I recommend a parameter that defaults to -1 (unlimited). This is necessary because large test outputs (2,000+ lines) are currently flooding the terminal and cutting off vital early-stage debug data. Providing a way to redirect this to a file would also be a great solution.

@gflarity
Copy link
Contributor Author

gflarity commented Jan 22, 2026

Can we implement a line-limit control for logs? I recommend a parameter that defaults to -1 (unlimited). This is necessary because large test outputs (2,000+ lines) are currently flooding the terminal and cutting off vital early-stage debug data. Providing a way to redirect this to a file would also be a great solution.

Ah, yes I can see how this is annoying. I'll add make it configurable, stdout vs write to file with a timestamp. Still stdout for github CI unfortunately.

@gflarity gflarity dismissed stale reviews from shayasoolin and danbar2 via ea8fa8a January 22, 2026 18:13
@gflarity gflarity requested a review from Ronkahn21 January 22, 2026 18:14
@gflarity gflarity force-pushed the diag_gather_all_operator_logs branch from ea8fa8a to 37f5db4 Compare January 22, 2026 18:14
@gflarity gflarity force-pushed the diag_gather_all_operator_logs branch from c608346 to 2616a2e Compare January 22, 2026 22:40
@gflarity gflarity requested a review from Ronkahn21 January 26, 2026 15:50
@gflarity gflarity requested a review from Ronkahn21 January 27, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants