Auto-MNNVL: add ComputeDomain component for PCS controller #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmuel-runai
requested review from
Ronkahn21,
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
danbar2
previously approved these changes
Jan 22, 2026
Contributor
|
I'm taking a look at why these E2E tests are failing. Something already stands out though. Early tests are failing to clean up resources and causing the remaining tests to be skipped. Try rebasing from main, I added a PR to clean up better which should help. |
Contributor
|
From the logs, you can see the controller continuously retrying: |
shayasoolin
reviewed
Jan 25, 2026
Implement ComputeDomain lifecycle management in the PodCliqueSet controller to enable automatic Multi-Node NVLink support for GPU workloads. - Add ComputeDomain component with Sync/Delete operations - Handle scale-out (create CDs) and scale-in (remove CDs) - Use finalizers to protect CDs from accidental deletion - Register component in PCS reconcile order before PodClique - Add comprehensive unit tests with fake client support
shmuel-runai
force-pushed
the
RUN-35354/cd-component
branch
from
1e511cb to
f8c56d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
ref: GREP-270
Implement ComputeDomain lifecycle management in the PodCliqueSet controller to enable automatic Multi-Node NVLink support for GPU workloads.