Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ EXPOSE 8001

# Set default environment variables (can be overridden)
ENV MODEL_EXPRESS_SERVER_PORT=8001
ENV MODEL_EXPRESS_LOGGING_LEVEL=info
ENV MODEL_EXPRESS_LOG_LEVEL=info
ENV MODEL_EXPRESS_DATABASE_PATH=/app/models.db
ENV MODEL_EXPRESS_CACHE_DIRECTORY=/app/cache
ENV HF_HUB_CACHE=/app/cache
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ docker-compose up --build

# Or build and run manually
docker build -t model-express .
docker run -p 8000:8000 model-express
docker run -p 8001:8001 model-express
```

### Option 3: Kubernetes Deployment
Expand Down
4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ services:
context: .
dockerfile: Dockerfile
ports:
- "8000:8000"
- "8001:8001"
environment:
- MODEL_EXPRESS_SERVER_PORT=8000
- MODEL_EXPRESS_SERVER_PORT=8001
- MODEL_EXPRESS_LOG_LEVEL=info
restart: unless-stopped
4 changes: 2 additions & 2 deletions docs/CLI.md
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ modelexpress-cli --format json model list | jq -r '.models[].name'
- name: Test ModelExpress server
run: |
# Start server in background
./target/release/model-express-server &
./target/release/modelexpress-server &
sleep 5

# Test health endpoint
Expand Down Expand Up @@ -364,7 +364,7 @@ Set default values using environment variables:
export MODEL_EXPRESS_ENDPOINT="https://my-server.com:8001"

# Set default cache path
export MODEL_EXPRESS_CACHE_PATH="/path/to/storage"
export MODEL_EXPRESS_CACHE_DIRECTORY="/path/to/storage"

# Use the CLI without specifying endpoint or storage path
modelexpress-cli health
Expand Down
2 changes: 1 addition & 1 deletion modelexpress_common/src/client_config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub struct ClientArgs {
pub timeout: Option<u64>,

/// Cache path override
#[arg(long, env = "MODEL_EXPRESS_CACHE_PATH")]
#[arg(long, env = "MODEL_EXPRESS_CACHE_DIRECTORY")]
pub cache_path: Option<PathBuf>,

/// Log level
Expand Down
4 changes: 2 additions & 2 deletions test_client.sh
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ setup_test_env() {
mkdir -p "$TEST_CACHE_PATH"

# Set environment variables
export MODEL_EXPRESS_CACHE_PATH="$TEST_CACHE_PATH"
export MODEL_EXPRESS_CACHE_DIRECTORY="$TEST_CACHE_PATH"
export MODEL_EXPRESS_SERVER_ENDPOINT="$SERVER_ENDPOINT"
export RUST_LOG=info

Expand Down Expand Up @@ -192,7 +192,7 @@ test_cache_discovery() {

# Test environment variable discovery
print_status "Testing environment variable discovery..."
MODEL_EXPRESS_CACHE_PATH="$TEST_CACHE_PATH" cargo run --bin cache_cli list || {
MODEL_EXPRESS_CACHE_DIRECTORY="$TEST_CACHE_PATH" cargo run --bin cache_cli list || {
print_error "Environment variable discovery failed"
return 1
}
Expand Down
Loading