DEVICE/API: Add NIXL device-side logging infrastructure #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Shalev <[email protected]>
|
👋 Hi michal-shalev! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
tvegas1
reviewed
Oct 9, 2025
|
|
||
| /* Helper macro to print a message from NIXL device function including the | ||
| * thread and block indices, file, line, and function */ | ||
| #define nixl_device_printf(_title, _fmt, ...) \ |
| * thread and block indices, file, line, and function */ | ||
| #define nixl_device_printf(_title, _fmt, ...) \ | ||
| printf("(%5d:%5d) %5s %s:%d %s: " _fmt "\n", threadIdx.x, blockIdx.x, _title, \ | ||
| __FILE__, __LINE__, __func__, ##__VA_ARGS__) |
There was a problem hiding this comment.
probably __func__ not needed, maybe left pad file and pad lines with %-5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add device-side logging infrastructure to NIXL with
nixl_device_errormacro and use it to log when UCX backend operations fail.Why?
Without NIXL-layer logging, we lose calling context when UCX errors occur in device code. Each layer should log its own context for proper debugging.
How?
Added
nixl_device_printfandnixl_device_errormacros that print thread/block info, file, line, and function. Used innixlGpuConvertUcsStatusandnixlGpuGetXferStatusto log "UCX backend error" when errors occur.