Skip to content

Save checkpoints in a run-specific dir with config file. #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

HoagyC
Copy link
Contributor

@HoagyC HoagyC commented Dec 11, 2023

This changes pipeline.py so that checkpoints from a run are saved in a folder labelled by the starting time of the run. It also saves a json with the config in the file.

Also adds the git hash to the saved config file so that we can trace which version of the code a model was run with.

@alan-cooney
Copy link
Collaborator

We could also use the release version of sparse_autoencoder? Might be a bit more readable (and would also work for anyone who pip installs the lib). This can then be set in the checkpoint metadata

Note this would need to setup https://setuptools-git-versioning.readthedocs.io/en/v1.13.5/index.html

@alan-cooney
Copy link
Collaborator

Let me know what you think - happy to sort the merge conflicts myself afterwards btw

@HoagyC
Copy link
Contributor Author

HoagyC commented Dec 11, 2023

Hey, been looking into this, seems like I can use importlib.metadata.version? Might be wrong somehow but setuptools integration with Poetry seems fiddly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants