Public release, 2025-07 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgibbon
reviewed
Jul 14, 2025
pyproject.toml
Outdated
Comment on lines
46
to
48
| [tool.ruff] | ||
| exclude = ["fme/ace/models/makani_fcn2/**"] | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| [tool.ruff] | |
| exclude = ["fme/ace/models/makani_fcn2/**"] |
elynnwu
reviewed
Jul 14, 2025
Contributor
elynnwu
left a comment
elynnwu
left a comment
There was a problem hiding this comment.
I did a diff from full-model (52cf66b5a) and have one minor comment
| in the dataset configuration. See :class:`fme.ace.XarrayDataConfig` for an example. | ||
| While netCDFs files are specified in the example, zarr stores are also compatible, e.g., | ||
| specifying the parent folder containing the zarr store directory as the ``path``, setting ``engine`` to "zarr", and setting ``file_pattern`` to "<zarr_store_name>.zarr" | ||
| in the dataset configuration. See :class:`fme.ace.XarrayDataConfig` for more information. |
Contributor
There was a problem hiding this comment.
[nit] Further down on line 44, links to zenodo but full-model uses https://huggingface.co/allenai/ACE2-ERA5, which is more consistent with the text above
Contributor
Author
There was a problem hiding this comment.
Good catch. The challenge of trying to maintain two versions of the docs between public and private ...
elynnwu
reviewed
Jul 14, 2025
fme/__init__.py
Outdated
| "using_gpu", | ||
| "weighted_std", | ||
| "ace", | ||
| "coupled", |
elynnwu
reviewed
Jul 14, 2025
fme/ace/test_ocean_train.py
Outdated
Comment on lines
27
to
28
| Inspired by fme/coupled/data_loading/test_data_loader.py::_save_netcdf | ||
| and fme.ace.testing.fv3gfs_data.save_nd_netcdf. |
Contributor
There was a problem hiding this comment.
[nit] this path doesn't exist but it's just in the comment so I don't think it matters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the codebase to a recent commit on
full-model(1607488c).This PR was created by the following steps, similar to the prior release in December 2024:
full-modelto specify which files should be copied over, and filter the git history to only include these files.acecalledlinear-history.release-2025-07branch on ace, and then squash-merginglinear-historyinto this branch usinggit merge linear-history --squash --allow-unrelated-histories --strategy-option theirs(necessary because GH will not allow opening a PR with incompatible histories, but--allow-unrelated-historiesresults in a branch that is "compatible").acethat are not the public releases, done by runninggit cherry-pick --no-commit <ref>..<ref>over the various sets of commits made between public releases, and then squashing these sets of changes into one commit.