fv3kube: remove gfdl_mp_nml.rh_ins and gfdl_mp_nml.ql_gen from SHiELD PIRE-like config
#2406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were removed in the 202411 release of the dynamical core. See NOAA-GFDL/GFDL_atmos_cubed_sphere#364 for more details. These namelist parameters were already obviated—i.e. they had no impact on simulations—but had just not been removed. We remove them from the config now to avoid errors when running with the latest code base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
gfdl_mp_nml.rh_insandgfdl_mp_nml.ql_genfrom the SHiELD PIRE-like config in fv3kube. These namelist parameters were removed in the 202411 release of the dynamical core. See NOAA-GFDL/GFDL_atmos_cubed_sphere#364 for more details. These namelist parameters were already obviated—i.e. they had no impact on simulations—but had just not been removed. We remove them from the config now to avoid errors when running with the latest code base.I have verified that removing these namelist parameters in simulations with the old codebase has no effect on simulations (i.e. it would not have changed the answers of any simulations that we ran based on this config).