[DO NOT MERGE] eval #3588 i:1: Prevent contributors from relabelling imported annotation properties (opencode/openai/gpt-5.4, .)#594
Open
cmungall wants to merge 2 commits into
Conversation
Model: openai/gpt-5.4 Issue repo: obophenotype/cell-ontology Agent config: ai4curation/cl-agent-config@v3:. Iteration: 1 Artifacts: https://github.com/ai4curation/eval-ont-agent-cl/actions/runs/25977575607#artifacts
Member
Author
|
📋 Traces: traces/25977575607 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Issue
#3588: Prevent contributors from relabelling imported annotation properties
Original PR (human solution)
#3589: Dont relabel imported annotation properties ter
Agent Commits
Note: This PR diff shows ONLY the agent's changes. The baseline is eval_base_branch.
Agent Response - PR Comments
This change addresses issue #3588 by removing imported annotation-property relabeling that had been reintroduced into
src/ontology/cl-edit.owl.What changed:
AnnotationAssertion(rdfs:label ...)axioms for importedoboInOwl:*annotation properties:SubsetProperty,consider,hasBroadSynonym,hasDbXref,hasExactSynonym,hasNarrowSynonym,hasRelatedSynonym,hasSynonymType, andinSubset.docs/annotation_properties.mdstating that importedoboInOwl:*annotation properties already get labels from the import chain and should not be relabeled insrc/ontology/cl-edit.owlbecause that causes spurious serialization diffs.Rationale:
cl-edit.owlis unnecessary and creates unstable diffs, especially for properties likehasDbXrefthat can serialize with conflicting imported labels.src/ontology/cl-edit.owlordocs/, the preventative follow-up was implemented as contributor documentation rather than a CI/script change.Checks completed:
__issue_context__.json.rdfs:labelaxioms present insrc/ontology/cl-edit.owl.AnnotationAssertion(rdfs:label oboInOwl:...)assertions insrc/ontology/cl-edit.owl.Local commit:
e22e743-Remove imported oboInOwl property relabels🤖 Generated by opencode agent
opencodeopenai/gpt-5.4ai4curation/cl-agent-config@v3:.1Agent Response - Issue Comments
Addressed in local commit
e22e743.I removed the redundant
rdfs:labelassertions for importedoboInOwl:*annotation properties fromsrc/ontology/cl-edit.owland added a short contributor note indocs/annotation_properties.mdto discourage reintroducing them, since they cause spurious serialization diffs.Changes committed in PR #.
🤖 Generated by opencode agent
opencodeopenai/gpt-5.4ai4curation/cl-agent-config@v3:.1Experiment Config
openai/gpt-5.4ai4curation/cl-agent-config@v3:.1https://href.li/?eval-base-issue-3588See workflow artifacts for full agent trace.