[pull] master from arp242:master #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check the last line of output from go version This makes `gopher.vim` work in my particular environment, where `go` is a shell wrapper and is outputting extra text before printing the version. Instead of expecting the entirety of `go version` output to contain the version information, this instead uses only the last line. * Refactor 'version_check' to return the error message and expect that the 'go version' may be in the middle of the 'go version' output * Fix the tests They failed because \n isn't expanded in single quotes * Revert echoerr This was initially changed, because I was not seeing the error messages, but this should be addressed separately, if actually needed. * Remove accidentally committed file, and fix lint warning Co-authored-by: Martin Tournoij <[email protected]>
Should give greater guarantee people actually see this; see #34
Rather obscure edge case, but might as well fix it. Also set compiler to "go" for go.mod.
The previous implementation was correct (AFAIK) and IMHO better, because
method names didn't get highlighted:
fun (t T) delete() { }
fun (t T) int() { }
But it's also very complex, and slow. I started getting noticable
slow-downs, which is a shame becase I spent quite some time optimising
the rest of the syntax.
So ... probably not worth it.
…nabled I'm not sure why I always applied the folding pattern (it's been a few years since I wrote it), but I can't find any good reason for it, and as far as I can see it works well. Maybe some other change affected this? Or maybe I was just stupid... It's rather slow for larger files; and actually runs out of memory in gtk.go in mattn/go-gtk.
* Add :GoFrob fill * Found another bug * Fix stuff * Remove fillswitch as it doesn't work with modules * Update docs * Fix bugs
(before/after)
TOTAL COUNT MATCH SLOWEST AVERAGE NAME PATTERN
0.043582 4117 100 0.000077 0.000011 goSingleDecl \v(^\s*)@<=(import|var|const) [^(]
0.004676 3619 100 0.000037 0.000001 goSingleDecl \v^\s*\zs%(import|var|const)\ze [^(]
It's a bit faster.
e.g.:
var m = map[int]string{
LevelInfo: "X",
}
LevelInfo would get highlighted wrong
vim-dispatch parses every compiler and looks for strings roughly matching: CompilerSet makeprg=<program> It mentions in its help that simply making a comment with such a string will also work. That's what I've done here.
Better capture for slightly changed 1.14 test -v output.
Otherwise it would apply outside of structs
Can't really get this right...
…ispatch Make the compilers compatible with vim-dispatch.
* Allow *no* auto-download of tools (default is to auto-download) * Allow to install tools in the default $GOBIN (default is to install tools in <plugin>/tools/bin * Create command that forces download of all tools
-> was added in 8.1.1803 (Aug 2019)
GoCoverage should operate on windows, not buffers
Breaks ":GoCoverage clear"; better to have this bug than that one. Issue #48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )