Skip to content

If the key is still valid, don't generate it by click - #9

Draft
unkcpz wants to merge 1 commit into
mainfrom
fix/5/validity-key-not-regenerate
Draft

If the key is still valid, don't generate it by click#9
unkcpz wants to merge 1 commit into
mainfrom
fix/5/validity-key-not-regenerate

Conversation

@unkcpz

@unkcpz unkcpz commented Oct 16, 2023

Copy link
Copy Markdown
Member

No description provided.

@unkcpz
unkcpz requested a review from yakutovicha October 16, 2023 15:14
@unkcpz

unkcpz commented Oct 16, 2023

Copy link
Copy Markdown
Member Author

This PR can go first before #6 .

@yakutovicha yakutovicha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doing this? What if it is 6pm, and I am about to go home. The key is valid for 2 hours, and I want to keep AiiDA running for the night. What do I do?

@unkcpz

unkcpz commented Oct 18, 2023

Copy link
Copy Markdown
Member Author

Good point, I was thinking about it but forgot it during the implementation. Do you think it is okay that I use _parse_validity_time and only do this if the valid time is greater than let's say 23.5h? Just to avoid keep on click the update will run out of 5 times limitation per day.

@yakutovicha

Copy link
Copy Markdown
Member

Maybe add a switch "Allow valid keys update" and enable it by default. Or, better add a confirmation dialog "Are you sure? The key is still valid."

@unkcpz

unkcpz commented Oct 20, 2023

Copy link
Copy Markdown
Member Author

dialog "Are you sure? The key is still valid."

Good idea, since this is not an urgent feature, I want to with some react magic as an experiment.

@unkcpz
unkcpz marked this pull request as draft October 20, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants