Lazy-docs - #919
Open
edan-bainglass wants to merge 3 commits into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 71.26% 71.28% +0.01%
==========================================
Files 114 114
Lines 7097 7097
==========================================
+ Hits 5058 5059 +1
+ Misses 2039 2038 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
superstar54
requested changes
Nov 8, 2024
superstar54
left a comment
superstar54
left a comment
Member
There was a problem hiding this comment.
Thanks for the docs, it's very helpful to get the whole picture of the design, and for reviewing the PR.
I added some quick comments. I am going to review the lazy-loading PR, and may add more comments later.
Comment on lines
+89
to
+93
| # Controller methods | ||
| # EXAMPLE | ||
| def _on_trait_change(self, change): | ||
| # Update widgets based on model changes | ||
| ... |
Member
There was a problem hiding this comment.
I think you also need to show how the widgets in the UI trigger the model update.
Member
Author
There was a problem hiding this comment.
I think this is covered by two-way links
# Two-way link - trait is synchronized between widget and model
ipw.link(
(self._model, "trait"),
(widget, "value"),
)
edan-bainglass
force-pushed
the
lazy-loading
branch
3 times, most recently
from
November 14, 2024 05:48
578a997 to
a65beed
Compare
edan-bainglass
force-pushed
the
lazy-docs
branch
2 times, most recently
from
November 14, 2024 19:59
1a4741c to
55fe31a
Compare
danielhollas
self-requested a review
November 14, 2024 20:38
edan-bainglass
force-pushed
the
lazy-docs
branch
from
November 20, 2024 12:34
55fe31a to
3689c7c
Compare
edan-bainglass
force-pushed
the
lazy-docs
branch
from
December 13, 2024 06:00
d8bde58 to
b8d3997
Compare
edan-bainglass
force-pushed
the
lazy-docs
branch
from
January 13, 2025 19:40
b8d3997 to
c1512a0
Compare
edan-bainglass
force-pushed
the
lazy-docs
branch
from
January 13, 2025 22:25
25bfe9c to
9947992
Compare
danielhollas
removed their request for review
May 1, 2026 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides documentation to accompany the changes made in the lazy-loading PR (#802)