Skip to content

Conversation

@bastonero
Copy link
Contributor

Fixes #6865

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.17%. Comparing base (fb723a9) to head (fe9e4d7).

Files with missing lines Patch % Lines
src/aiida/orm/nodes/process/workflow/workchain.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6884      +/-   ##
==========================================
+ Coverage   79.13%   79.17%   +0.05%     
==========================================
  Files         565      567       +2     
  Lines       43391    43416      +25     
==========================================
+ Hits        34331    34370      +39     
+ Misses       9060     9046      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agoscinski agoscinski force-pushed the feat/workchain-tools branch 2 times, most recently from eedeba5 to 4980623 Compare June 3, 2025 20:39
This is an implementation of feature request in issue aiidateam#6865. Further
changes:
* Extend the typing hints from `tools` output as it can return `None`
* Add tests for `CalcJobNode.tools` and `WorkChainNode.tools`

---------

Co-authored-by: Alexander Goscinski <[email protected]>
@agoscinski
Copy link
Contributor

@bastonero sorry I did not give you heads up. I wanted to merge it and was about to finalize it but then there was an error in the REST API which I was not able to fix in the time

@bastonero
Copy link
Contributor Author

@agoscinski no worries, and thanks a lot! is there still this issue? do we need to add/do something else/more?

@agoscinski
Copy link
Contributor

@eimrek can you have a look? It is a test error in the REST API

@mbercx
Copy link
Member

mbercx commented Nov 27, 2025

I'm very interested in having this feature. Adding tools to my work chains would be sexy AF. Any chance we can get this merged soon? @eimrek can you look into the blocking issue during the coding week?

@eimrek
Copy link
Member

eimrek commented Nov 27, 2025

I'm very interested in having this feature. Adding tools to my work chains would be sexy AF. Any chance we can get this merged soon? @eimrek can you look into the blocking issue during the coding week?

thanks for the note, sure, I can try to get this done during the coding week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Tools plugin to WorkChains

4 participants