-
Notifications
You must be signed in to change notification settings - Fork 234
WIP: Support python 3.14 #7074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: Support python 3.14 #7074
Conversation
| - alembic~=1.8 | ||
| - archive-path~=0.4.2 | ||
| - asyncssh~=2.19.0 | ||
| - asyncssh~=2.21.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bump is needed as 2.20.0 version had some Python 3.14 fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - archive-path~=0.4.2 | ||
| - asyncssh~=2.19.0 | ||
| - asyncssh~=2.21.0 | ||
| - circus~=0.19.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a PR with tests for 3.14
circus-tent/circus#1233
| - asyncssh~=2.21.0 | ||
| - circus~=0.19.0 | ||
| - click-spinner~=0.1.8 | ||
| - click<8.3,>=8.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw: get-annotations dependency can be dropped once we drop support for Python 3.9
| - jinja2~=3.0 | ||
| - kiwipy[rmq]~=0.8.4 | ||
| - kiwipy[rmq]>=0.8.4 | ||
| - importlib-metadata~=6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw: importlib-metadata can be dropped once we drop 3.9 in favour of stdlib importlib.metadata, see comment in: aiida/plugins/entry_point.py
| - tabulate<0.10.0,>=0.9.0 | ||
| - tqdm~=4.45 | ||
| - typing-extensions~=4.1 | ||
| - upf_to_json~=0.9.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tabulate seems to work with 3.14
astanin/python-tabulate#372
| - tqdm~=4.45 | ||
| - typing-extensions~=4.1 | ||
| - upf_to_json~=0.9.2 | ||
| - wrapt~=1.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapt just had a 2.0 release: https://wrapt.readthedocs.io/en/latest/changes.html#version-2-0-0
Looking at the changelog it seems that it should be safe to upgrade (we're only using wrapt.decorator).
We could also choose to support both 1.x and 2.x, as there might be aiida plugins that depend on wrapt as well.
Possibly the biggest reason to update is that the package is now typed. :-)
WIP but seems to work! The biggest obstackle is the change in behaviour in
asyncio.get_event_loopwhich now throws aRuntimeErrorif there's no loop. This requires fixes in both aiida-core and plumpy. The correspondingplumpyPR is aiidateam/plumpy#329.Otherwise things seems to just work.