Fix script to autogenerate module re-imports and __all__ attributes #7091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script was not working ever since we moved to the src/aiida layout. :-( This also includes: - fixes for Python 3.14 (deprecations from ast module) - preservation of `from __future__` imports - fixes for compatibility with ruff
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7091 +/- ##
==========================================
- Coverage 79.61% 79.61% -0.00%
==========================================
Files 566 566
Lines 43536 43533 -3
==========================================
- Hits 34657 34654 -3
Misses 8879 8879 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
commented
Nov 6, 2025
|
|
||
| auto_content = ( | ||
| ['', '# AUTO-GENERATED'] | ||
| + ['', '# fmt: off', ''] |
Collaborator
Author
There was a problem hiding this comment.
It was necessary to remove the extra empty lines to appease ruff
danielhollas
commented
Nov 6, 2025
| continue | ||
|
|
||
| names = [n.s for n in all_token.value.elts] | ||
| names = [n.value for n in all_token.value.elts] # type: ignore[attr-defined] |
Collaborator
Author
There was a problem hiding this comment.
I ran the script through mypy to make sure I haven't screwed up.
danielhollas
commented
Nov 6, 2025
| bad_all.setdefault('__all__ is not list/tuple', []).append(str(path.relative_to(folder_path))) | ||
| continue | ||
|
|
||
| if not all(isinstance(el, ast.Str) for el in all_token.value.elts): |
Collaborator
Author
There was a problem hiding this comment.
ast.Str has been removed in Python 3.14
danielhollas
commented
Nov 6, 2025
| 'DUMP_PROGRESS_BAR_FORMAT', | ||
| 'ORM_TYPE_TO_REGISTRY', | ||
| 'REGISTRY_TO_ORM_TYPE', | ||
| 'DumpMode', |
Collaborator
Author
There was a problem hiding this comment.
DumpMode is defined in _dumping.config, not here
danielhollas
commented
Nov 6, 2025
| 'ProgressReporterAbstract', | ||
| 'RemoteOperationError', | ||
| 'StashMode', | ||
| 'StorageBackupError', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7090