Release v2.7.5 - #7581
Merged
Merged
Conversation
On a `StashingError` in `COPY` mode, `stash_calculation` cleaned up with `rmtree(target_base / uuid[:2])`, wiping the whole two-character shard and with it every other stash whose UUID shares that prefix. Remove only the failed calculation's own `target_basepath`. (cherry picked from commit c22a06d) Removed the logging change because it is not present in 2.7.x.
`node_outputs/` was created only when a calculation had a `SinglefileData` or `FolderData` output, but the full, unfiltered list of output nodes was then dumped into it. Whether an output reached disk therefore depended on its siblings rather than on itself: an `ArrayData` was written when a file-like output happened to sit beside it, and dropped when it was alone. The same held for every other repository-backed type the `isinstance` check did not name, among them `BandsData`, `TrajectoryData`, `XyData`, and a `KpointsData` holding an explicit k-point list. Dump each output that carries repository content, which is the per-node question `_dump_calculation_io_files` already answers when it decides what to write. The directory is created lazily there, so calculations whose outputs live entirely in the database still leave no empty `node_outputs/`, and neither does an output whose repository is empty. (cherry picked from commit 92c21cc)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
agoscinski
added a commit
that referenced
this pull request
Aug 26, 2026
agoscinski
force-pushed
the
release/v2.7.5
branch
from
August 26, 2026 14:30
7ca9159 to
6d6a880
Compare
agoscinski
marked this pull request as ready for review
August 26, 2026 14:31
agoscinski
added a commit
that referenced
this pull request
Aug 26, 2026
agoscinski
force-pushed
the
release/v2.7.5
branch
from
August 26, 2026 14:32
6d6a880 to
4fd057b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## support/2.7.x #7581 +/- ##
==============================================
Coverage 79.20% 79.20%
==============================================
Files 565 565
Lines 43615 43615
==============================================
Hits 34541 34541
Misses 9074 9074 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
agoscinski
added a commit
that referenced
this pull request
Aug 26, 2026
agoscinski
force-pushed
the
release/v2.7.5
branch
from
August 26, 2026 14:45
4fd057b to
af9e6a3
Compare
agoscinski
added a commit
that referenced
this pull request
Aug 26, 2026
agoscinski
force-pushed
the
release/v2.7.5
branch
from
August 26, 2026 15:25
af9e6a3 to
112c04e
Compare
agoscinski
force-pushed
the
release/v2.7.5
branch
from
August 26, 2026 19:56
112c04e to
62aa415
Compare
agoscinski
added a commit
that referenced
this pull request
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not add #7572 because the logic is not present yet it 2.7.x so the fix makes sense