Skip to content

Fix typehint of traversal_rules - #7597

Draft
agoscinski wants to merge 1 commit into
aiidateam:mainfrom
agoscinski:fix/graph-typehint
Draft

Fix typehint of traversal_rules#7597
agoscinski wants to merge 1 commit into
aiidateam:mainfrom
agoscinski:fix/graph-typehint

Conversation

@agoscinski

@agoscinski agoscinski commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

The code is crap. I just don't want to forget this issue. I think API break is kind of needed, it's a wrong type hint.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.70%. Comparing base (92c21cc) to head (98dd0ba).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/tools/graph/graph_traversers.py 85.72% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7597      +/-   ##
==========================================
- Coverage   80.70%   80.70%   -0.00%     
==========================================
  Files         581      581              
  Lines       47138    47157      +19     
==========================================
+ Hits        38040    38053      +13     
- Misses       9098     9104       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant