Merged
Conversation
The `empty_config` context manager is used for some of the testing infrastructure of the installation commands. It relied on some methods for adapting the AiiDA configuration folder, whose API has been changed in aiidateam/aiida-core@9baf3ca Here we adapt the context manager to rely on the new API using the `AiiDAConfigDir`.
The `test_constructor_invalid` test in the `data/pseudo/test_pseudo.py` module was testing that the `PseudoPotentialData` constructor would fail with no input arguments. This behaviour was the expected behavior of the parent `SinglefileData` class, from which `PseudoPotentialData` inherits its constructor. However, the `SinglefileData` constructor now accepts no input arguments since the changes in: aiidateam/aiida-core@958bfd0 Which have been released in v2.7.0 of `aiida-core`. Hence, the test is no longer correct/necessary, and is removed here.
This was referenced Jul 1, 2025
Merged
edan-bainglass
approved these changes
Jul 1, 2025
Comment on lines
-35
to
-40
| def test_constructor_invalid(): | ||
| """Test the constructor for invalid arguments.""" | ||
| with pytest.raises(TypeError, match='missing 1 required positional argument'): | ||
| PseudoPotentialData() | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Never mind. You explain it clearly in the commit message 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
empty_configcontext manager is used for some of the testing infrastructure of the installation commands. It relied on some methods for adapting the AiiDA configuration folder, whose API has been changed inaiidateam/aiida-core@9baf3ca
Here we adapt the
empty_configcontext manager to rely on the new API using theAiiDAConfigDir.