Skip to content

Loosen click to coincide with aiida-core#202

Merged
mbercx merged 1 commit intoaiidateam:mainfrom
oerc0122:bump-click
Mar 25, 2026
Merged

Loosen click to coincide with aiida-core#202
mbercx merged 1 commit intoaiidateam:mainfrom
oerc0122:bump-click

Conversation

@oerc0122
Copy link
Copy Markdown
Contributor

Bump click version to allow 8.3 to coincide with aiida-core.

@mbercx
Copy link
Copy Markdown
Member

mbercx commented Mar 25, 2026

Thanks @oerc0122! Seems reasonable to me to update the click dependency here, now that aiida-core v2.8 supports click v8.2 (since aiidateam/aiida-core@44ef2a1). I still considered if we should keep click v8.0 in the supported range, but aiida-core has click v8.1 as a lower bound since v2.1, and we currently set aiida-core~=2.6.

I did a bit of housekeeping in #203, the CI should pass now, but install tests are flaky due to unstable connection to www.pseudo-dojo.org:

E             requests.exceptions.ConnectTimeout: HTTPConnectionPool(host='www.pseudo-dojo.org', port=80): Max retries exceeded with url: /pseudos/nc-sr-04_pbe_standard_psp8.tgz (Caused by ConnectTimeoutError(<HTTPConnection(host='www.pseudo-dojo.org', port=80) at 0x7f9373c4cda0>, 'Connection to www.pseudo-dojo.org timed out. (connect timeout=30)'))

Rerunning the test will most likely fix the failure, but it's becoming more and more worth looking into #195.

EDIT: Yup, just rerunning (twice 😅 ) fixed the transient connection issue. So this is good to go for me. Will get a release out soon.

Quick question though: were you running into issues because you're relying on a different package that requires click v8.2? Because aiida-core still supports v8.1 AFAIK.

@mbercx mbercx merged commit 7ea7bd5 into aiidateam:main Mar 25, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants