refactor(styles): consolidate page headers & unify landing section headings - #179
Draft
khsrali wants to merge 1 commit into
Draft
refactor(styles): consolidate page headers & unify landing section headings#179khsrali wants to merge 1 commit into
khsrali wants to merge 1 commit into
Conversation
Deploying aiida-website with
|
| Latest commit: |
79d516f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a17ebe7a.aiida-website.pages.dev |
| Branch Preview URL: | https://uniform-style.aiida-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. Addresses #176 and #163 (style uniformity).
#176 — one shared page-header primitive
The site had 5 near-duplicate page-header implementations with inconsistent markup (
<section>vs<header>) and per-file mobile overrides:.section-header·.eco-hero·.docs-hero·.reg-hero·.blog-header(+ their-subvariants)..page-header/.page-header-subprimitive toglobal.css(loaded on every page), including the mobile and subtitle-link styles.<header class="page-header">(ecosystem, docs, plugin registry, blog, team, events, use-cases, graph gallery, testimonials, acknowledgements, science).@mediaoverrides.#163 — uniform landing section headings
Landing
<h2>s were all over the place: sizes 2.5 / 2 / 1.8 / 1.25rem, mixed alignment, and multiple colors (rotating orange/green/blue accent bars, blue text). The citation section also had a solid tinted background that didn't cross-fade with its siblings..section-headingclass — 2rem / 700 /--color-text/ a single blue (--color-primary) accent bar — applied to every live section heading, with a--leftvariant for the two carousel headers (news, testimonials) that share a flex row with nav arrows.variant="panel"Cite is unchanged.Net −123 lines (mostly removed duplication).
Decisions taken (open to change)
One thing worth an eye: "Supported by" is now a full section heading (was a small uppercase label) — bigger over the logo strip; easy to tone down.
Verification
astro build— 161 pages, no errors.Kept as a draft pending confirmation on the decisions above; will switch the issue links to
Closesonce approved.