Codex-generated pull request - #4
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fcaea72c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const DEFAULT_NATIVE_API_BASE_URL = 'http://10.0.2.2:3001/api'; | ||
| const API_BASE_URL = |
There was a problem hiding this comment.
The native fallback API base URL is hardcoded to http://10.0.2.2:3001/api, but this Android project targets API 35 and does not declare android:usesCleartextTraffic, so cleartext HTTP requests are blocked on modern Android unless users manually provide an HTTPS override in env. That makes the default native networking path fail out of the box for emulator/device runs.
Useful? React with 👍 / 👎.
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
|
@copilot view |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da926c3520
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Context of the app under test. | ||
| Context appContext = InstrumentationRegistry.getInstrumentation().getTargetContext(); | ||
|
|
||
| assertEquals("com.getcapacitor.app", appContext.getPackageName()); |
There was a problem hiding this comment.
The new instrumented test hardcodes com.getcapacitor.app, but this project’s Android applicationId is com.gifts.coupleconnection (and flavor-specific variants), so connectedAndroidTest will fail every time even when the app is healthy. This makes Android CI/test runs noisy and masks real regressions.
Useful? React with 👍 / 👎.
|
|
||
| ANDROID_SDK_ROOT="${ANDROID_SDK_ROOT:-$HOME/android-sdk}" | ||
| CMDLINE_VERSION="11076708" | ||
| TOOLS_ZIP="commandlinetools-linux-${CMDLINE_VERSION}_latest.zip" |
There was a problem hiding this comment.
The SDK bootstrap script always downloads commandlinetools-linux-...zip, so running npm run android:sdk:setup on macOS or Windows pulls the wrong binaries and sdkmanager cannot run there. Because this is the documented setup path, non-Linux developers are blocked from provisioning the Android toolchain.
Useful? React with 👍 / 👎.
|
@copilot 审查代码并解决之前vercel的报错（Build Canceled |
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task