Skip to content

Conversation

JeppeKlitgaard
Copy link
Contributor

cached_stampede now features the same cache control arguments
as the cached decorator

`cached_stampede` now features the same cache control arguments
as the `cached` decorator
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.55%. Comparing base (77976b0) to head (d1668d3).
⚠️ Report is 330 commits behind head on master.

Files with missing lines Patch % Lines
aiocache/decorators.py 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #510       +/-   ##
===========================================
+ Coverage   56.72%   99.55%   +42.82%     
===========================================
  Files          33       36        +3     
  Lines        2928     3564      +636     
  Branches      155      450      +295     
===========================================
+ Hits         1661     3548     +1887     
+ Misses       1243       12     -1231     
+ Partials       24        4       -20     
Flag Coverage Δ
unit 99.49% <66.66%> (+42.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
aiocache/decorators.py 98.70% <77.77%> (+20.18%) ⬆️

... and 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77976b0...d1668d3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@argaen
Copy link
Member

argaen commented Oct 16, 2020

@JeppeKlitgaard thanks for this, mind adding tests? There should be ones for the cached decorator that you can just copy paste

@Dreamsorcerer
Copy link
Member

As mentioned, tests please, otherwise we'll close this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants