Use constant-time compare in BasicAuth#531
Open
Cycloctane wants to merge 1 commit intoaio-libs:masterfrom
Open
Use constant-time compare in BasicAuth#531Cycloctane wants to merge 1 commit intoaio-libs:masterfrom
Cycloctane wants to merge 1 commit intoaio-libs:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Cycloctane
force-pushed
the
password_compare
branch
from
0e3e6e1 to
bdaf0aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Using string comparison (
==) to compare passwords may be vulnerable to timing attack under some scenario. This pr replaces it with constant-time compare (hmac.compare_digest) on password to reduce the risk.Are there changes in behavior for the user?
Related issue number
Checklist