Skip to content

Close the socket if there's a failure in start_connection() #10464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 9 commits into from
Feb 20, 2025
+39 −1

review feedback -- add explicit typing

b3fcd38
Select commit
Loading
Failed to load commit list.
Merged

Close the socket if there's a failure in start_connection() #10464

review feedback -- add explicit typing
b3fcd38
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis succeeded Feb 18, 2025 in 0s

Performance Gate Passed

Summary

⚡ 2 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_one_hundred_get_requests_iter_chunks_on_512kib_chunked_payload[pyloop] 130.8 ms 108 ms +21.04%
⚡ test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop] 188.6 ms 166 ms +13.59%
View more details on CodSpeed HQ