Revert: Close the socket if there's a failure in start_connection() #10464 #10656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10464 fixes #10617 alternative fix is MagicStack/uvloop#646
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
added
backport-3.11
backport-3.12
CodSpeed Performance ReportMerging #10656 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10656 +/- ##
==========================================
+ Coverage 97.79% 98.71% +0.92%
==========================================
Files 126 125 -1
Lines 37623 37439 -184
Branches 2132 2076 -56
==========================================
+ Hits 36792 36957 +165
+ Misses 652 335 -317
+ Partials 179 147 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10657 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
…10464 (#10656) Reverts #10464 While this change improved the situation for uvloop users, it caused a regression with `SelectorEventLoop` (issue #10617) The alternative fix is MagicStack/uvloop#646 (not merged at the time of this PR) issue #10617 appears to be very similar to python/cpython@d5aeccf If someone can come up with a working reproducer for #10617 we can revisit this. cc @top-oai Minimal implementation that shows on cancellation the socket is cleaned up without the explicit `close` #10617 (comment) so this should be unneeded unless I've missed something (very possible with all the moving parts here) ## Related issue number fixes #10617 (cherry picked from commit 06db052)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10658 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
…10464 (#10656) Reverts #10464 While this change improved the situation for uvloop users, it caused a regression with `SelectorEventLoop` (issue #10617) The alternative fix is MagicStack/uvloop#646 (not merged at the time of this PR) issue #10617 appears to be very similar to python/cpython@d5aeccf If someone can come up with a working reproducer for #10617 we can revisit this. cc @top-oai Minimal implementation that shows on cancellation the socket is cleaned up without the explicit `close` #10617 (comment) so this should be unneeded unless I've missed something (very possible with all the moving parts here) ## Related issue number fixes #10617 (cherry picked from commit 06db052)
bdraco
added a commit
that referenced
this pull request
Apr 1, 2025
…'s a failure in start_connection() #10464 (#10657) **This is a backport of PR #10656 as merged into master (06db052).** Reverts #10464 While this change improved the situation for uvloop users, it caused a regression with `SelectorEventLoop` (issue #10617) The alternative fix is MagicStack/uvloop#646 (not merged at the time of this PR) issue #10617 appears to be very similar to python/cpython@d5aeccf If someone can come up with a working reproducer for #10617 we can revisit this. cc @top-oai Minimal implementation that shows on cancellation the socket is cleaned up without the explicit `close` #10617 (comment) so this should be unneeded unless I've missed something (very possible with all the moving parts here) ## Related issue number fixes #10617 Co-authored-by: J. Nick Koston <[email protected]>
bdraco
pushed a commit
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10464
While this change improved the situation for uvloop users, it caused a regression with
SelectorEventLoop(issue #10617)The alternative fix is MagicStack/uvloop#646 (not merged at the time of this PR)
issue #10617 appears to be very similar to python/cpython@d5aeccf
If someone can come up with a working reproducer for #10617 we can revisit this.
cc @top-oai
Minimal implementation that shows on cancellation the socket is cleaned up without the explicit
close#10617 (comment) so this should be unneeded unless I've missed something (very possible with all the moving parts here)Related issue number
fixes #10617