-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add benchmark requests without session and alternating clients #10848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was a bit of a blind spot in our benchmarks noticed when I was looking at resolver object churn in #10847
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10848 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 125 125
Lines 37858 37892 +34
Branches 2091 2094 +3
=======================================
+ Hits 37366 37400 +34
Misses 343 343
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10848 will not alter performanceComparing Summary
Benchmarks breakdown
|
At the same time, I don't think users should expect high performance from the simple API. We tell them to use a session in production code and even do it from the very first example in the docs.. |
I agree. We shouldn't put too much effort into improving this case. I think only the multi-session case matters |
Yeah its the multisession case that actually matters. Testing Home Assistant startup on a production instance: 116 setups used the shared session 48 DNSResolver objects in memory |
Checked a few more instances using Home Assistant’s
The number of |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10866 🤖 @patchback |
(cherry picked from commit 97eae19)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10867 🤖 @patchback |
(cherry picked from commit 97eae19)
…ssion and alternating clients (#10866) Co-authored-by: J. Nick Koston <[email protected]> resolver object churn in #10847
…ssion and alternating clients (#10867) Co-authored-by: J. Nick Koston <[email protected]> resolver object churn in #10847
This was a bit of a blind spot in our benchmarks
noticed when I was looking at resolver object churn in #10847