[3.11] Fixup for Cython version 3.1.0 #10849
Conversation
With Cython v3.1.0 + aiohttp v3.11.18 will generate following error
message:
cython -3 -o aiohttp/_websocket/reader_c.c aiohttp/_websocket/reader_c.py -I aiohttp -Werror
Error compiling Cython file:
------------------------------------------------------------
...
def exception(self) -> Optional[BaseException]:
return self._exception
def set_exception(
self,
exc: "BaseException",
^
------------------------------------------------------------
aiohttp/_websocket/reader_c.py:82:13: Strings should no longer be used for type declarations. Use 'cython.int' etc. directly.
This PR include minimal changes backport from master branch, in order to
fix above issue with Cython v3.1.0.
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
git clean -xdf
git submodule sync --recursive
git submodule update --recursive --init
git submodule foreach --recursive git checkout -- .
git submodule foreach --recursive git clean -xdf
make generate-llhttp
tar zcvf ../python-aiohttp_3.11.18.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-aiohttp.spec ../python-aiohttp_3.11.18-1.spec
cp ../python*-aiohttp*3.11.18*.{gz,xz,spec,dsc} /osc/home\:alvistack/aio-libs-aiohttp-3.11.18/
rm -rf ../python*-aiohttp*3.11.18*.*
See aio-libs#10849
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.11 #10849 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 126 126
Lines 37682 37682
Branches 4555 4555
=======================================
Hits 36972 36972
Misses 534 534
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10849 will not alter performanceComparing Summary
|
|
PRs should typically go through master first. |
|
Additionally, this requires a change note. |
|
Oh, and the |
|
Looks like this one is a bit messy since this code exists on 3.12 as well. It was updated on I think we should keep the signature as-is for 3.12/3.11 but remove the quotes. So a PR to 3.12 and than backport to 3.11 is likely the path here. |
|
Thanks for the PR. I went ahead and made the changes in #10849 |
With Cython v3.1.0 + aiohttp v3.11.18 will generate following error message:
This PR include minimal changes backport from master branch, in order to fix above issue with Cython v3.1.0.
What do these changes do?
Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.