Skip to content

remove use of deprecated policy API from tests #10851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 18, 2025
Merged

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 11, 2025

What do these changes do?

Removes the use of deprecated policy APIs from aiohttp tests

Are there changes in behavior for the user?

None

Is it a substantial burden for the maintainers to support this?

Related issue number

Fixes #10850

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@kumaraditya303 kumaraditya303 requested a review from asvetlov as a code owner May 11, 2025 09:04
Copy link

codspeed-hq bot commented May 11, 2025

CodSpeed Performance Report

Merging #10851 will not alter performance

Comparing kumaraditya303:dev (888da76) with master (0e9eccb)

Summary

✅ 58 untouched benchmarks

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this! Here's a few initial observations.

I'll leave this for Sam to review as he's the last one to look into the test infra recently.

Plz make sure to include a change note or two — the plugin is user-facing and the tests could use a contrib change log entry but that's optional.

@webknjaz webknjaz requested review from Dreamsorcerer and bdraco and removed request for asvetlov May 11, 2025 19:31
Copy link
Member

@Dreamsorcerer Dreamsorcerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine to merge, I'll resolve any conflicts in my PR after.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change the fixture injection syntax..

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (0e9eccb) to head (888da76).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10851      +/-   ##
==========================================
- Coverage   98.70%   98.70%   -0.01%     
==========================================
  Files         125      125              
  Lines       37858    37852       -6     
  Branches     2091     2091              
==========================================
- Hits        37369    37360       -9     
- Misses        341      343       +2     
- Partials      148      149       +1     
Flag Coverage Δ
CI-GHA 98.58% <100.00%> (-0.01%) ⬇️
OS-Linux 98.28% <69.23%> (+<0.01%) ⬆️
OS-Windows 96.40% <76.92%> (-0.02%) ⬇️
OS-macOS 97.40% <69.23%> (+<0.01%) ⬆️
Py-3.10.11 97.29% <100.00%> (-0.01%) ⬇️
Py-3.10.17 97.84% <69.23%> (+0.01%) ⬆️
Py-3.11.12 97.93% <69.23%> (+<0.01%) ⬆️
Py-3.11.9 97.38% <100.00%> (-0.01%) ⬇️
Py-3.12.10 98.35% <100.00%> (-0.01%) ⬇️
Py-3.13.3 98.33% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.15% <100.00%> (-0.01%) ⬇️
Py-3.9.22 97.70% <69.23%> (-0.01%) ⬇️
Py-pypy7.3.16 93.19% <38.46%> (-4.08%) ⬇️
VM-macos 97.40% <69.23%> (+<0.01%) ⬆️
VM-ubuntu 98.28% <69.23%> (+<0.01%) ⬆️
VM-windows 96.40% <76.92%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 12, 2025
@webknjaz
Copy link
Member

Here's the doc on authoring change log entries: https://docs.aiohttp.org/en/latest/contributing.html#changelog-update.
And here's the preview to help understand if it fits well: https://aiohttp--10851.org.readthedocs.build/en/10851/changes.html.

@kumaraditya303
Copy link
Contributor Author

@webknjaz @Dreamsorcerer PTAL, thanks

@Dreamsorcerer Dreamsorcerer added the backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot label May 15, 2025
@bdraco
Copy link
Member

bdraco commented May 16, 2025

There is a small chance 3.11 might still be around when Python 3.14 ships so maybe we should backport to 3.11 as well

@bdraco bdraco merged commit e5d1240 into aio-libs:master May 18, 2025
40 of 41 checks passed
@bdraco
Copy link
Member

bdraco commented May 18, 2025

Thanks!

Copy link
Contributor

patchback bot commented May 18, 2025

Backport to 3.12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply e5d1240 on top of patchback/backports/3.12/e5d1240babff6db6297e0d92f174446de19cf76d/pr-10851

Backporting merged PR #10851 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.12/e5d1240babff6db6297e0d92f174446de19cf76d/pr-10851 upstream/3.12
  4. Now, cherry-pick PR remove use of deprecated policy API from tests #10851 contents into that branch:
    $ git cherry-pick -x e5d1240babff6db6297e0d92f174446de19cf76d
    If it'll yell at you with something like fatal: Commit e5d1240babff6db6297e0d92f174446de19cf76d is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x e5d1240babff6db6297e0d92f174446de19cf76d
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR remove use of deprecated policy API from tests #10851 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.12/e5d1240babff6db6297e0d92f174446de19cf76d/pr-10851
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@bdraco
Copy link
Member

bdraco commented May 18, 2025

I'll take care of the backport

bdraco pushed a commit that referenced this pull request May 18, 2025
bdraco added a commit that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove use of deprecated policy APIs in aiohttp
4 participants