-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
remove use of deprecated policy API from tests #10851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #10851 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this! Here's a few initial observations.
I'll leave this for Sam to review as he's the last one to look into the test infra recently.
Plz make sure to include a change note or two — the plugin is user-facing and the tests could use a contrib change log entry but that's optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine to merge, I'll resolve any conflicts in my PR after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change the fixture injection syntax..
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10851 +/- ##
==========================================
- Coverage 98.70% 98.70% -0.01%
==========================================
Files 125 125
Lines 37858 37852 -6
Branches 2091 2091
==========================================
- Hits 37369 37360 -9
- Misses 341 343 +2
- Partials 148 149 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Here's the doc on authoring change log entries: https://docs.aiohttp.org/en/latest/contributing.html#changelog-update. |
@webknjaz @Dreamsorcerer PTAL, thanks |
There is a small chance 3.11 might still be around when Python 3.14 ships so maybe we should backport to 3.11 as well |
Thanks! |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e5d1240 on top of patchback/backports/3.12/e5d1240babff6db6297e0d92f174446de19cf76d/pr-10851 Backporting merged PR #10851 into master
🤖 @patchback |
I'll take care of the backport |
(cherry picked from commit e5d1240)
…I from tests (#10871) Co-authored-by: Kumar Aditya <[email protected]>
What do these changes do?
Removes the use of deprecated policy APIs from aiohttp tests
Are there changes in behavior for the user?
None
Is it a substantial burden for the maintainers to support this?
Related issue number
Fixes #10850
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.