-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
add Python 3.14 to CI #10872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add Python 3.14 to CI #10872
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10872 +/- ##
==========================================
- Coverage 98.81% 98.80% -0.02%
==========================================
Files 129 129
Lines 41366 41374 +8
Branches 2226 2227 +1
==========================================
+ Hits 40877 40879 +2
- Misses 339 344 +5
- Partials 150 151 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10872 will not alter performanceComparing Summary
|
@@ -3,15 +3,15 @@ | |||
blockbuster | |||
coverage | |||
freezegun | |||
isal | |||
isal; python_version < "3.14" # no wheel for 3.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't worth doing. Basic dependencies (like multidict) will not have 3.14 compatible releases until atleast the release candidate is out. We don't really want a load of version checks that need to be removed again shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, we usually don't start testing until the deps are ready, which is closer to the final release of CPython.. Not sure if it's worth doing this PR just yet.
What do these changes do?
This PR adds CI for Python 3.14. It skips tests which use isal as that doesn't has 3.14 wheels and is optional. I modified the requirements file to add markers to install isal and python-on-whales on less than Python 3.14 to fix the CI.
Are there changes in behavior for the user?
none
Is it a substantial burden for the maintainers to support this?
none
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.