Skip to content

add Python 3.14 to CI #10872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 18, 2025

What do these changes do?

This PR adds CI for Python 3.14. It skips tests which use isal as that doesn't has 3.14 wheels and is optional. I modified the requirements file to add markers to install isal and python-on-whales on less than Python 3.14 to fix the CI.

Are there changes in behavior for the user?

none

Is it a substantial burden for the maintainers to support this?

none

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

Copy link

codecov bot commented May 18, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.80%. Comparing base (c50f332) to head (7f9dc72).

Files with missing lines Patch % Lines
tests/conftest.py 45.45% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10872      +/-   ##
==========================================
- Coverage   98.81%   98.80%   -0.02%     
==========================================
  Files         129      129              
  Lines       41366    41374       +8     
  Branches     2226     2227       +1     
==========================================
+ Hits        40877    40879       +2     
- Misses        339      344       +5     
- Partials      150      151       +1     
Flag Coverage Δ
CI-GHA 98.69% <45.45%> (-0.02%) ⬇️
OS-Linux 98.41% <45.45%> (-0.02%) ⬇️
OS-Windows 96.66% <45.45%> (-0.03%) ⬇️
OS-macOS 97.60% <45.45%> (-0.02%) ⬇️
Py-3.10.11 97.49% <45.45%> (-0.03%) ⬇️
Py-3.10.17 98.00% <45.45%> (-0.01%) ⬇️
Py-3.11.12 98.07% <45.45%> (-0.02%) ⬇️
Py-3.11.9 97.56% <45.45%> (-0.02%) ⬇️
Py-3.12.10 98.46% <45.45%> (-0.02%) ⬇️
Py-3.13.3 98.45% <45.45%> (-0.03%) ⬇️
Py-3.9.13 97.37% <45.45%> (-0.02%) ⬇️
Py-3.9.22 97.88% <45.45%> (-0.01%) ⬇️
Py-pypy7.3.16 93.76% <45.45%> (+2.86%) ⬆️
VM-macos 97.60% <45.45%> (-0.02%) ⬇️
VM-ubuntu 98.41% <45.45%> (-0.02%) ⬇️
VM-windows 96.66% <45.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 18, 2025

CodSpeed Performance Report

Merging #10872 will not alter performance

Comparing kumaraditya303:py314 (7f9dc72) with master (c50f332)

Summary

✅ 59 untouched benchmarks

@kumaraditya303 kumaraditya303 marked this pull request as ready for review May 18, 2025 20:03
@@ -3,15 +3,15 @@
blockbuster
coverage
freezegun
isal
isal; python_version < "3.14" # no wheel for 3.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't worth doing. Basic dependencies (like multidict) will not have 3.14 compatible releases until atleast the release candidate is out. We don't really want a load of version checks that need to be removed again shortly.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we usually don't start testing until the deps are ready, which is closer to the final release of CPython.. Not sure if it's worth doing this PR just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants