Change ClientSession middlewares default to be an empty tuple #10959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added
the
backport-3.12
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10959 +/- ##
=======================================
Coverage 98.76% 98.76%
=======================================
Files 129 129
Lines 39541 39541
Branches 2185 2185
=======================================
+ Hits 39051 39054 +3
+ Misses 342 339 -3
Partials 148 148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10959 will not alter performanceComparing Summary
|
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10960 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 23, 2025
(cherry picked from commit cc234c6)
bdraco
added a commit
that referenced
this pull request
May 23, 2025
…default to be an empty tuple (#10960) Co-authored-by: J. Nick Koston <[email protected]> closes #10905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid one breaking change in 4.0 in when we make the other change in #10890 and remove
if effective_middlewares:closes #10905