Skip to content

Added Unofficial Tabdeal API to Built with aiohttp page #11009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MohsenHNSJ
Copy link

What do these changes do?

Adds Unofficial Tabdeal API package to Built with aiohttp documentation page.

Are there changes in behavior for the user?

No, only added a line in documentation.

Is it a substantial burden for the maintainers to support this?

No. The project is maintained by me and as I also use it for my own purposes, it will be maintained for the foreseeable future.

Related issue number

This is not related to any issues.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

Currently at alpha state, this project heavily depends on aiohttp for communicating with Tabdeal platform and services..
Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.82%. Comparing base (3a2a9b2) to head (5f7a32f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11009      +/-   ##
==========================================
- Coverage   98.82%   98.82%   -0.01%     
==========================================
  Files         129      129              
  Lines       41505    41505              
  Branches     2234     2234              
==========================================
- Hits        41019    41016       -3     
- Misses        337      340       +3     
  Partials      149      149              
Flag Coverage Δ
CI-GHA 98.70% <ø> (-0.01%) ⬇️
OS-Linux 98.42% <ø> (-0.01%) ⬇️
OS-Windows 96.68% <ø> (-0.01%) ⬇️
OS-macOS 97.61% <ø> (-0.01%) ⬇️
Py-3.10.11 97.38% <ø> (-0.01%) ⬇️
Py-3.10.17 97.89% <ø> (ø)
Py-3.11.12 98.05% <ø> (-0.02%) ⬇️
Py-3.11.9 97.56% <ø> (ø)
Py-3.12.10 98.45% <ø> (-0.01%) ⬇️
Py-3.13.3 98.44% <ø> (ø)
Py-3.9.13 97.27% <ø> (ø)
Py-3.9.22 97.76% <ø> (-0.02%) ⬇️
Py-pypy7.3.16 92.94% <ø> (+5.82%) ⬆️
VM-macos 97.61% <ø> (-0.01%) ⬇️
VM-ubuntu 98.42% <ø> (-0.01%) ⬇️
VM-windows 96.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 25, 2025

CodSpeed Performance Report

Merging #11009 will not alter performance

Comparing MohsenHNSJ:patch-1 (5f7a32f) with master (3a2a9b2)

Summary

✅ 59 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant