Right way of keeping module from destruction#11715
Right way of keeping module from destruction#11715vinnik-dmitry07 wants to merge 4 commits intoaio-libs:masterfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return ContentDisposition(disposition_type, params, filename) | ||
|
|
||
| def __del__(self, _warnings: Any = warnings) -> None: | ||
| def __del__(self, warnings_warn: Any = warnings.warn) -> None: |
Check notice
Code scanning / CodeQL
Overly complex `__del__` method Note
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11715 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 127 127
Lines 43558 43558
Branches 2320 2320
=======================================
+ Hits 43007 43008 +1
Misses 390 390
+ Partials 161 160 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11715 will not alter performanceComparing Summary
|
What exception? (your reproducer is not complete, and doesn't seem to reproduce on my machine) |
|
I had to look up why this was used in the first place. For anyone else, relevant part of the docs:
|
import traceback
import sys
import asyncio
import aiohttp
import traceback
def _unraisable_hook(unraisable, format_exception=traceback.format_exception):
tb_lines = format_exception(unraisable.exc_type, unraisable.exc_value, unraisable.exc_traceback)
tb_str = ''.join(tb_lines)
print(
tb_str,
'Unraisable exception error from %r',
getattr(unraisable, 'object', None),
(unraisable.exc_type, unraisable.exc_value, unraisable.exc_traceback),
f'{unraisable.exc_type.__name__}: {unraisable.exc_value}'
)
sys.unraisablehook = _unraisable_hook
class A:
def __init__(self):
asyncio.get_event_loop().run_until_complete(self.a())
raise
async def a(self):
aiohttp_session = aiohttp.ClientSession()
await aiohttp_session.request(
method='get',
url='https://google.com',
)
A() |
|
@vinnik-dmitry07 could you write a test for this at least? |
3 participants
To reproduce:
# Old example, look below for a new oneWhat do these changes do?
Fixes Exception ignored in sys.unraisablehook:
You should store the function not the module.
Are there changes in behavior for the user?
No.
Is it a substantial burden for the maintainers to support this?
No.