[PR #11737/f30f43e6 backport][3.14] Skip benchmarks in ci when running in fork repositories#11991
Conversation
Forks cannot use codspeed account, which can make benchmark job in ci fail if aiohttp contributors want to run test workflow on their forks. This pr make unnecessary steps skip if triggered workflow is not in the main repository. aiohttp contributors can now run github action workflows to test changes in their forks without unnecessary errors. Co-authored-by: 🇺🇦 Sviatoslav Sydorenko <webknjaz@redhat.com> (cherry picked from commit f30f43e)
|
Sometimes, when GitHub has troubles, it doesn't deliver webhook events to integrations (including GHA CI). In this case, closing+reopening the PR when GH outage is over, triggers it and other automations properly. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.14 #11991 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 128 128
Lines 44990 44990
Branches 2434 2434
=======================================
+ Hits 44190 44192 +2
+ Misses 618 615 -3
- Partials 182 183 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FYI, I'm finding that increasingly rare these days. Most of the time now it's just because there's no runners available or the previous commit's workflow is still cancelling, and it then works once it's caught up. |
|
Yeah, it depends. But sometimes GH disables webhook deliveries at the time of big outages manually. They the re-enable them once they fixed things. But they never retroactively deliver those events that happened during that period. This was mostly an educational comment for Rodrigo, though, since he tried achieving the same by pushing empty commits. |
Description
What do these changes do?
This is a backport of PR #11737 to the
3.14branch.Forks cannot use codspeed account, which can make benchmark job in ci fail if aiohttp contributors want to run test workflow on their forks. This change makes unnecessary steps skip if the triggered workflow is not in the main repository.
Are there changes in behavior for the user?
aiohttp contributors can now run github action workflows to test changes in their forks without unnecessary errors.
Is it a substantial burden for the maintainers to support this?
No, this is a straightforward CI configuration change.
Related issue number
Backport of #11737
Checklist
CONTRIBUTORS.txtCHANGES/folder