Skip to content

Change .decode_async() to .decode_iter()#12028

Merged
Dreamsorcerer merged 9 commits intomasterfrom
Dreamsorcerer-patch-6
Feb 5, 2026
Merged

Change .decode_async() to .decode_iter()#12028
Dreamsorcerer merged 9 commits intomasterfrom
Dreamsorcerer-patch-6

Conversation

@Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Feb 4, 2026

Pulling this out of #11966, as it should be backported to 3.13.
.decode_async() is not in any current release, so we can replace this now before it becomes part of the API.

Using an async generator is needed to fix the decompression code in #11966, plus it can help improve memory concerns in some parts of the code. In this implementation, the code will only ever yield once, but this will change in #11966.

@Dreamsorcerer Dreamsorcerer added backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Feb 4, 2026
@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Feb 4, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 4, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing Dreamsorcerer-patch-6 (ae030ad) with master (df0d897)1

Summary

✅ 59 untouched benchmarks

Footnotes

  1. No successful run was found on master (1b87279) during the generation of this report, so df0d897 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (df0d897) to head (ae030ad).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12028   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files         127      127           
  Lines       44655    44658    +3     
  Branches     2367     2372    +5     
=======================================
+ Hits        44101    44104    +3     
  Misses        393      393           
  Partials      161      161           
Flag Coverage Δ
CI-GHA 98.61% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.35% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.70% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.58% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.13% <100.00%> (+<0.01%) ⬆️
Py-3.10.19 97.62% <100.00%> (-0.01%) ⬇️
Py-3.11.14 97.82% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.34% <100.00%> (-0.01%) ⬇️
Py-3.12.10 97.43% <100.00%> (+<0.01%) ⬆️
Py-3.12.12 97.93% <100.00%> (+<0.01%) ⬆️
Py-3.13.11 98.17% <100.00%> (+<0.01%) ⬆️
Py-3.14.2 98.15% <100.00%> (-0.01%) ⬇️
Py-3.14.2t ?
Py-3.14.3t 97.23% <100.00%> (-0.01%) ⬇️
Py-pypy3.11.13-7.3.20 97.39% <100.00%> (+<0.01%) ⬆️
VM-macos 97.58% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.35% <100.00%> (+<0.01%) ⬆️
VM-windows 96.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: J. Nick Koston <nick@koston.org>
@Dreamsorcerer Dreamsorcerer merged commit 4bb9e6e into master Feb 5, 2026
63 of 73 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-6 branch February 5, 2026 16:29
@patchback
Copy link
Contributor

patchback bot commented Feb 5, 2026

Backport to 3.13: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 4bb9e6e on top of patchback/backports/3.13/4bb9e6e375c60ef305a860646df45de9155b3c7b/pr-12028

Backporting merged PR #12028 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.13/4bb9e6e375c60ef305a860646df45de9155b3c7b/pr-12028 upstream/3.13
  4. Now, cherry-pick PR Change .decode_async() to .decode_iter() #12028 contents into that branch:
    $ git cherry-pick -x 4bb9e6e375c60ef305a860646df45de9155b3c7b
    If it'll yell at you with something like fatal: Commit 4bb9e6e375c60ef305a860646df45de9155b3c7b is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 4bb9e6e375c60ef305a860646df45de9155b3c7b
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Change .decode_async() to .decode_iter() #12028 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.13/4bb9e6e375c60ef305a860646df45de9155b3c7b/pr-12028
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Contributor

patchback bot commented Feb 5, 2026

Backport to 3.14: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 4bb9e6e on top of patchback/backports/3.14/4bb9e6e375c60ef305a860646df45de9155b3c7b/pr-12028

Backporting merged PR #12028 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.14/4bb9e6e375c60ef305a860646df45de9155b3c7b/pr-12028 upstream/3.14
  4. Now, cherry-pick PR Change .decode_async() to .decode_iter() #12028 contents into that branch:
    $ git cherry-pick -x 4bb9e6e375c60ef305a860646df45de9155b3c7b
    If it'll yell at you with something like fatal: Commit 4bb9e6e375c60ef305a860646df45de9155b3c7b is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 4bb9e6e375c60ef305a860646df45de9155b3c7b
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Change .decode_async() to .decode_iter() #12028 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.14/4bb9e6e375c60ef305a860646df45de9155b3c7b/pr-12028
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer added a commit that referenced this pull request Feb 5, 2026
Dreamsorcerer added a commit that referenced this pull request Feb 5, 2026
Dreamsorcerer added a commit that referenced this pull request Feb 5, 2026
Dreamsorcerer added a commit that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments