Change .decode_async() to .decode_iter()#12028
Conversation
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12028 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 127 127
Lines 44655 44658 +3
Branches 2367 2372 +5
=======================================
+ Hits 44101 44104 +3
Misses 393 393
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: J. Nick Koston <nick@koston.org>
Backport to 3.13: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 4bb9e6e on top of patchback/backports/3.13/4bb9e6e375c60ef305a860646df45de9155b3c7b/pr-12028 Backporting merged PR #12028 into master
🤖 @patchback |
Backport to 3.14: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 4bb9e6e on top of patchback/backports/3.14/4bb9e6e375c60ef305a860646df45de9155b3c7b/pr-12028 Backporting merged PR #12028 into master
🤖 @patchback |
(cherry picked from commit 4bb9e6e)
(cherry picked from commit 4bb9e6e)
Pulling this out of #11966, as it should be backported to 3.13.
.decode_async() is not in any current release, so we can replace this now before it becomes part of the API.
Using an async generator is needed to fix the decompression code in #11966, plus it can help improve memory concerns in some parts of the code. In this implementation, the code will only ever yield once, but this will change in #11966.