-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add support for Android and iOS platforms #12220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timrid
wants to merge
5
commits into
aio-libs:master
Choose a base branch
from
timrid:android-and-ios-wheels
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+392
−168
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ddf04a6
Add support for Android and iOS platforms in CI/CD workflow
timrid 1103992
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 165104f
Add unittests in CI for android and ios
timrid bb36a1a
Merge commit 'd9f920760634a62234af5dcc12db10ae62ba9704' into android-…
timrid 257947d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Added wheels for Android and iOS platforms -- by :user:`timrid`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,10 +48,10 @@ dynamic = [ | |
|
|
||
| [project.optional-dependencies] | ||
| speedups = [ | ||
| "aiodns >= 3.3.0", | ||
| "Brotli >= 1.2; platform_python_implementation == 'CPython'", | ||
| "aiodns >= 3.3.0; sys_platform != 'android' and sys_platform != 'ios'", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you could make a PR to pycares to support this, we could probably get this resolved pretty quick. Unless there's a technical difficulty in supporting these platforms? |
||
| "Brotli >= 1.2; platform_python_implementation == 'CPython' and sys_platform != 'android' and sys_platform != 'ios'", | ||
| "brotlicffi >= 1.2; platform_python_implementation != 'CPython'", | ||
| "backports.zstd; platform_python_implementation == 'CPython' and python_version < '3.14'", | ||
| "backports.zstd; platform_python_implementation == 'CPython' and python_version < '3.14' and sys_platform != 'android' and sys_platform != 'ios'", | ||
| ] | ||
|
|
||
| [[project.maintainers]] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| -r runtime-deps.in | ||
|
|
||
| gunicorn | ||
| uvloop; platform_system != "Windows" and implementation_name == "cpython" # MagicStack/uvloop#14 | ||
| uvloop; platform_system != "Windows" and implementation_name == "cpython" and sys_platform != 'android' and sys_platform != 'ios' # MagicStack/uvloop#14 | ||
| winloop; platform_system == "Windows" and implementation_name == "cpython" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow is missing the coverage steps, which is why codecov is complaining.