Add TypeDict object for typehinting for Exception handler callbacks#574
Open
Vizonex wants to merge 10 commits intoaio-libs:masterfrom
Open
Add TypeDict object for typehinting for Exception handler callbacks#574Vizonex wants to merge 10 commits intoaio-libs:masterfrom
Vizonex wants to merge 10 commits intoaio-libs:masterfrom
Conversation
for more information, see https://pre-commit.ci
…onex/aiojobs into ExceptionHandler-Improvement
for more information, see https://pre-commit.ci
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
for more information, see https://pre-commit.ci
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
for more information, see https://pre-commit.ci
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Member
Author
|
@Dreamsorcerer I'll come back sometime in a couple of hours later today to mark a few mypy things off as ignorable because the default handler expects a something other than a context instead of something else. Here's the error from the workflow if you need a bit of context something to mark these as truthy in the python code might be nessesary... |
Member
|
aiojobs/_scheduler.py:239:63 is essentially a bug/limitation in mypy. The others are typing issues in our code that should be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These changes are made to better reflect the documentation on Exception Handlers as mentioned in #565
Might need a little help & Guidance with this one :/
Are there changes in behavior for the user?
Typehinting changes for Exception Handler Callbacks mainly meant to assist and add context from the provided documentation
Related issue number
Fixes #565
Checklist