Add SA executemany compiled cache support #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 92.28% 92.32% +0.03%
==========================================
Files 9 9
Lines 1180 1186 +6
Branches 172 174 +2
==========================================
+ Hits 1089 1095 +6
Misses 64 64
Partials 27 27
Continue to review full report at Codecov.
|
terricain
reviewed
Jan 20, 2019
|
Other than that list comprehension, it looks great 😄 |
|
Okay, so I dropped the extra checks. Turns out those were not actually needed plus they were a perf hit when adding larger amounts of rows. Also added a testcase for DELETE :) |
katajakasa
force-pushed
the
add-executemany-compiled-cache
branch
from
0807cbd to
9183e27
Compare
|
This good to go now? |
|
@terrycain Yes, this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compiled_cache support for SAConnection.executemany. Add tests for INSERT and UPDATE cases.