Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 86.50% 85.69% -0.81%
==========================================
Files 12 12
Lines 2082 2076 -6
Branches 341 341
==========================================
- Hits 1801 1779 -22
- Misses 216 232 +16
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4 tasks
ab47f38 to
ec58727
Compare
ec58727 to
4c555f3
Compare
Collaborator
Author
|
I'm not sure about the |
with await pool syntax
Collaborator
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Deprecated method
Pool.getwas removedDeprecated
with await poolsyntax was removed.Are there changes in behavior for the user?
Yes, see above.
Related issue number
no
Checklist
CHANGES.txt