Skip to content

Conversation

RA80533
Copy link
Contributor

@RA80533 RA80533 commented Apr 27, 2023

What do these changes do?

The PR implements PEP 561 – Distributing and Packaging Type Information.

Are there changes in behavior for the user?

Developers using the package should now be able to take advantage of the type annotations in the project.

Related issue number

Resolves #421

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@jettify
Copy link
Member

jettify commented May 3, 2023

I think we can merge this one once all typing in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type hints are not readily available through Pylance in VS Code

2 participants