Resolve all flake8 errors#588
Open
loqs wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 97.71% 97.77% +0.05%
==========================================
Files 23 23
Lines 5700 5701 +1
Branches 351 351
==========================================
+ Hits 5570 5574 +4
+ Misses 83 79 -4
- Partials 47 48 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
These were removed in commit 8d81f96. This reduces the number of flake8 errors from 1775 to 4. Global ignores: ANN002: Missing type annotation for *args ANN003: Missing type annotation for **kwargs ANN101: Missing type annotation for self in method ANN102: Missing type annotation for cls in classmethod Fixed per-file-ignores: aiosmtpd/tests/test_*:ANN001 Related settings: min-coverage-percents = 12 suppress-none-returning = True suppress-dummy-args = True allow-untyped-defs = True
Global name is declared but never assigned to within that scope. Fix by removing unnecessary 'nonlocal thread' declarations in test_server.py.
Use of pytest.warns() without a match parameter. Add match parameter to pytest.warns for specificity.
Multiline container is not broken after opening character. Fix by adding line break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Restore flake8 related settings removed in commit 8d81f96 reducing the number of flake8 errors from 1775 to 4. The remaining 4 flake8 errors are each fixed in their own commit.
Are there changes in behavior for the user?
No.
Related issue number
Related #544.
Checklist
qa{py36,py37,py38,py39}-{nocov,cov,diffcov}{py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs{py36,pypy3}-{nocov,cov,diffcov}, qapy36-{nocov,cov,diffcov}, qa, docsNEWS.rstfile