Adjust interface test SKIP_METHODS for Python 3.15.0a2#723
Open
musicinmybrain wants to merge 2 commits intoaio-libs:masterfrom
Open
Adjust interface test SKIP_METHODS for Python 3.15.0a2#723musicinmybrain wants to merge 2 commits intoaio-libs:masterfrom
musicinmybrain wants to merge 2 commits intoaio-libs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 94.90% 94.91% +0.01%
==========================================
Files 10 10
Lines 726 728 +2
Branches 48 48
==========================================
+ Hits 689 691 +2
Misses 13 13
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefanor
reviewed
Dec 5, 2025
| "__slots__", | ||
| "__static_attributes__", | ||
| "__firstlineno__", | ||
| # Since Python 3.15.0a2: https://github.com/python/cpython/pull/132345 |
|
I confirm I see this issue on 3.14 also, any chance to merge this? This is needed to fix workflow on main : https://github.com/aio-libs/frozenlist/actions/runs/21348618966/job/61441268047#step:15:38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes a regression in
TestFrozenList.test_ifacesince Python 3.15.0a2, discovered in preliminary downstream integration testing in Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=2416992), due to hidden internal__annotate_func__and__annotations_cache__keys added to the class dict in python/cpython#132345.This PR simply adds them to the
SKIP_METHODSforTestFrozenList.test_iface, indicating that they aren’t part of the interface we need to provide.Are there changes in behavior for the user?
No, this is only a testing change.
Related issue number
N/A
Checklist
CONTRIBUTORS.txtI think that this is not needed for such a trivial change.CHANGESfolder