Open
Conversation
CodSpeed Performance ReportMerging #727 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 95.40% 95.40% -0.01%
==========================================
Files 5 5
Lines 1721 1719 -2
Branches 154 154
==========================================
- Hits 1642 1640 -2
Misses 52 52
Partials 27 27 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In a multithreaded environment, it is possible that nowait methods may be called in event loops other than the one in which asynchronous methods are called. As a result, simultaneous binding to two different event loops is possible, because of which some methods will not work. This PR fixes this bug and ensures that RuntimeError is safely raised.
Side effect: nowait methods no longer depend on the event loop (and do not raise a RuntimeError when used from a different event loop).
Are there changes in behavior for the user?
There are no behavior changes for users.