Skip to content

Fix md_get_all() return value#1194

Merged
asvetlov merged 1 commit intoaio-libs:masterfrom
asvetlov:fix-getall-retval
Jun 24, 2025
Merged

Fix md_get_all() return value#1194
asvetlov merged 1 commit intoaio-libs:masterfrom
asvetlov:fix-getall-retval

Conversation

@asvetlov
Copy link
Member

It is a follow-up PR for #1187 that corrects retval of internal md_get_all() function.

@asvetlov asvetlov added the bot:chronographer:skip This PR does not need to include a change note label Jun 24, 2025
@asvetlov
Copy link
Member Author

asvetlov commented Jun 24, 2025

Thanks @Vizonex for catching.

The PR doesn't need a changenote because it corrects an internal function, and #1187 has not been released yet.

Actually, the retval is not used yet but the work is a preparation for #1183

@asvetlov asvetlov enabled auto-merge (squash) June 24, 2025 07:47
@asvetlov asvetlov merged commit c90fade into aio-libs:master Jun 24, 2025
62 checks passed
@asvetlov asvetlov deleted the fix-getall-retval branch June 24, 2025 07:59
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 24, 2025

CodSpeed Performance Report

Merging #1194 will degrade performances by 32.5%

Comparing asvetlov:fix-getall-retval (764b3a4) with master (eeb048f)

Summary

❌ 2 regressions
✅ 242 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cimultidict_getall_istr_miss[py] 246.6 µs 362 µs -31.88%
test_multidict_getall_str_miss[ci-py] 244.1 µs 361.6 µs -32.5%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments