Fix missing space in error message and docs/docstring issues#1295
Closed
veeceey wants to merge 1 commit intoaio-libs:masterfrom
Closed
Fix missing space in error message and docs/docstring issues#1295veeceey wants to merge 1 commit intoaio-libs:masterfrom
veeceey wants to merge 1 commit intoaio-libs:masterfrom
Conversation
- Fix missing space in ValueError message in _parse_args: the error previously read "element #0has length" instead of "element #0 has length" - Fix CIMultiDictProxy docs incorrectly stating it inherits from MultiDict when it actually inherits from MultiDictProxy - Fix "explicitly hand" -> "explicitly by hand" in istr docs - Fix "anount" -> "amount" typo in two code comments - Fix mismatched parenthesis in items() docstrings: was "*(key, value) pairs)" with unmatched RST emphasis marker, now "((key, value) pairs)" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Best to send separate changes separately. It's a bad tone to smash together unrelated stuff. You might want to learn about atomic changes and conventions of using Git. |
Contributor
Author
|
Closing this PR and splitting into separate atomic changes per review feedback:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrormessage in_parse_args()— the error previously read"multidict update sequence element #0has length 3; 2 is required"(note#0has) instead of the intended"multidict update sequence element #0 has length 3; 2 is required"CIMultiDictProxydocumentation incorrectly stating it is inherited fromMultiDictwhen it actually inherits fromMultiDictProxyistrdocumentation sectionupdate()andmerge())items()docstrings — was*(key, value) pairs)(unmatched*emphasis and extra)) now((key, value) pairs)Details
The error message bug is in the implicit string concatenation on lines 834-835 of
_multidict_py.py:Test plan
🤖 Generated with Claude Code