Skip to content

Fix missing space in error message and docs/docstring issues#1295

Closed
veeceey wants to merge 1 commit intoaio-libs:masterfrom
veeceey:fix/error-message-and-docs-typos
Closed

Fix missing space in error message and docs/docstring issues#1295
veeceey wants to merge 1 commit intoaio-libs:masterfrom
veeceey:fix/error-message-and-docs-typos

Conversation

@veeceey
Copy link
Contributor

@veeceey veeceey commented Feb 10, 2026

Summary

  • Bug fix: Fix missing space in ValueError message in _parse_args() — the error previously read "multidict update sequence element #0has length 3; 2 is required" (note #0has) instead of the intended "multidict update sequence element #0 has length 3; 2 is required"
  • Docs fix: Fix CIMultiDictProxy documentation incorrectly stating it is inherited from MultiDict when it actually inherits from MultiDictProxy
  • Docs fix: Fix "explicitly hand" → "explicitly by hand" in the istr documentation section
  • Typo fix: Fix "anount" → "amount" in two code comments (in update() and merge())
  • Docstring fix: Fix mismatched parenthesis/broken RST markup in items() docstrings — was *(key, value) pairs) (unmatched * emphasis and extra )) now ((key, value) pairs)

Details

The error message bug is in the implicit string concatenation on lines 834-835 of _multidict_py.py:

# Before (no space between f-strings):
f"multidict update sequence element #{pos}"
f"has length {len(item)}; 2 is required"
# Produces: "multidict update sequence element #0has length 3; 2 is required"

# After:
f"multidict update sequence element #{pos} "
f"has length {len(item)}; 2 is required"
# Produces: "multidict update sequence element #0 has length 3; 2 is required"

Test plan

  • Verified the error message fix produces correct output with a manual test
  • All changes are straightforward string/comment fixes with no behavioral impact beyond the corrected error message

🤖 Generated with Claude Code

- Fix missing space in ValueError message in _parse_args: the error
  previously read "element #0has length" instead of "element #0 has length"
- Fix CIMultiDictProxy docs incorrectly stating it inherits from
  MultiDict when it actually inherits from MultiDictProxy
- Fix "explicitly hand" -> "explicitly by hand" in istr docs
- Fix "anount" -> "amount" typo in two code comments
- Fix mismatched parenthesis in items() docstrings: was "*(key, value)
  pairs)" with unmatched RST emphasis marker, now "((key, value) pairs)"

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2026

Merging this PR will not alter performance

✅ 245 untouched benchmarks


Comparing veeceey:fix/error-message-and-docs-typos (75a9675) with master (8416839)

Open in CodSpeed

@webknjaz
Copy link
Member

webknjaz commented Feb 10, 2026

Best to send separate changes separately. It's a bad tone to smash together unrelated stuff. You might want to learn about atomic changes and conventions of using Git.
Also, in some places the justification is unclear and needs to be relatable. I don't see any research done into the history/context of asterisks in there, for example.
One change is straightforward, indeed. I wish it was atomic and thus acceptable.
Oh, and the blobs of text don't need to be overly verbose — it's better if they relay exactly enough context and are accurate instead.

@veeceey
Copy link
Contributor Author

veeceey commented Feb 10, 2026

Closing this PR and splitting into separate atomic changes per review feedback:

@veeceey veeceey closed this Feb 10, 2026
@github-project-automation github-project-automation bot moved this from 🤦‍♂️ LLM/“AI” slop 🤖 to 🌈 Done 🦄 in 📅 Procrastinating in public 😵‍💫 Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments